Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Group Tree module package #863

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Upgrade Group Tree module package #863

wants to merge 8 commits into from
+246 −114

Conversation

Anders2303
Copy link
Collaborator

@Anders2303 Anders2303 commented Feb 4, 2025 •
edited
Loading

@Anders2303 Anders2303 marked this pull request as ready for review February 7, 2025 09:40
jorgenherje
jorgenherje requested changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@jorgenherje jorgenherje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Reviewed code and performed minor testing in module. Some minor comments.

Regarding new component in webviz-subsurface-components: Really nice work!

backend_py/primary/primary/services/flow_network_assembler/flow_network_assembler.py Outdated Show resolved Hide resolved
backend_py/primary/primary/services/flow_network_assembler/flow_network_assembler.py Outdated Show resolved Hide resolved
backend_py/primary/primary/services/flow_network_assembler/flow_network_assembler.py Outdated Show resolved Hide resolved
backend_py/primary/primary/services/flow_network_assembler/flow_network_assembler.py Show resolved Hide resolved
frontend/src/modules/FlowNetwork/view.tsx Outdated Show resolved Hide resolved
frontend/src/modules/FlowNetwork/view.tsx Outdated Show resolved Hide resolved
@jorgenherje jorgenherje self-requested a review February 12, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgenherje jorgenherje Awaiting requested review from jorgenherje

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Anders2303 @jorgenherje