Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some files in sub directories #3412

Merged
merged 4 commits into from
Jul 4, 2024
Merged

Conversation

Jarod42
Copy link
Contributor

@Jarod42 Jarod42 commented Jun 28, 2024

No description provided.

Copy link
Collaborator

@AJenbo AJenbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I especially appreciate the cleanup done to the includes 👍

Looks like line endings where also fixed in a couple of files which actually accounts for the majority of diff in the PR.

@Eric-01
Copy link

Eric-01 commented Jul 1, 2024

Actually, I think it would be a good idea to run ClangFormat (and perhaps other formatters for other languages as well) on the entire codebase in one single commit, so that future commits don't contain 5 intended changes and 50 completely unrelated formatting improvements here and there made on the user's behalf by the formatter.

Other than that, I really appreciate the work you put into this project, as someone who hasn't contributed any new features or even bug fixes myself and just uses CodeLite for my own needs. Eranif can't keep up with everything (as seen in the delay when reviewing and merging pull requests), and you're doing a really good job 👍

@Jarod42
Copy link
Contributor Author

Jarod42 commented Jul 2, 2024

@Eric-01 : Running clang-format on whole repo should be done by Eranif directly (I think I even see a script in the repo) when no PRs is opened (or by CI bot, I have that in my TODO list for personal projects).

I try to minimize unrelated changes. Here, it is EOL consistency (mismatch \r\n \n between copyright header and regular source) that was changed by editor :-/

@eranif eranif merged commit 387f921 into eranif:master Jul 4, 2024
3 checks passed
@Jarod42 Jarod42 deleted the Directories branch July 4, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants