ERC-6900 RI Test CI

[DRAFT] refactor/SMA: Inheritable Account Refactor #558

Sign in to view logs

Triggered via pull request August 7, 2024 19:51

Zer0dot

synchronize #133

zer0dot/inheritable-account

Status Failure

Total duration 34s

Artifacts –

test.yml

on: pull_request

Run Forge Tests (optimized-test-deep)

Run Forge Tests (default)

Annotations

7 errors and 6 warnings

Run Forge Tests (optimized-test-deep)

Process completed with exit code 1.

Run Forge Tests (default)

Process completed with exit code 1.

Run Linters: src/account/AccountFactory.sol#L114

'_getAddressFallbackSigner' should not start with _

Run Linters: src/account/SemiModularAccount.sol#L10

imported name IModuleManager is not used

Run Linters: src/account/SemiModularAccount.sol#L11

imported name IValidation is not used

Run Linters: src/modules/validation/SingleSignerValidation.sol#L9

imported name ECDSA is not used

Run Linters

Process completed with exit code 1.

Run Forge Tests (optimized-test-deep)

The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Run Forge Tests (default)

The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Run Linters

The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, pnpm/action-setup@v2, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Run Linters: src/account/AccountFactory.sol#L114

Function order is incorrect, public view function can not go after public pure function (line 110)

Run Linters: src/account/SemiModularAccount.sol#L51

Function order is incorrect, internal function can not go after internal view function (line 35)

Run Linters: src/account/UpgradeableModularAccount.sol#L366

Function order is incorrect, public view function can not go after internal view function (line 342)