Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip signature length encoding on final sig and add type safety #192

Merged

Conversation

jaypaik
Copy link
Collaborator

@jaypaik jaypaik commented Oct 8, 2024

@jaypaik jaypaik requested a review from a team October 8, 2024 15:34
@jaypaik jaypaik force-pushed the 10-08-feat_skip_signature_length_encoding_on_final_sig branch from 8ad332a to 43d9d45 Compare October 8, 2024 15:36
@jaypaik jaypaik force-pushed the 10-07-refactor_organize_files branch from 7cc3457 to 5b69346 Compare October 8, 2024 19:01
Base automatically changed from 10-07-refactor_organize_files to develop October 8, 2024 19:12
@jaypaik jaypaik force-pushed the 10-08-feat_skip_signature_length_encoding_on_final_sig branch from 43d9d45 to c823956 Compare October 8, 2024 19:12
Copy link

Summary by Octane

New Contracts

  • ModuleSignatureUtils.sol: ModuleSignatureUtils encodes modular account validation signatures, supporting pre-hooks and custom validation data.

Updated Contracts

  • SparseCalldataSegmentLib.sol: The smart contract now includes segment indices, omits segment body extraction, and directly handles segment validation, enhancing segment management.
  • ValidationConfigLib.sol: Introduced ValidationFlags type for enhanced flag handling in smart contract validation functions.
  • ReturnDataModuleMocks.sol: Updated the smart contract's validation method and enhanced signature handling by integrating ModuleSignatureUtils and ModuleEntityLib.
  • AccountTestBase.sol: Enhanced smart contract with added signature utilities, removing redundant signature encoding functions.

🔗 Commit Hash: c823956

This comment was marked as resolved.

@jaypaik jaypaik merged commit 45a9e8a into develop Oct 8, 2024
4 checks passed
@jaypaik jaypaik deleted the 10-08-feat_skip_signature_length_encoding_on_final_sig branch October 8, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants