Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install git into conda so user doesn't have to install globally #527

Open
wants to merge 3 commits into
base: alltalkbeta
Choose a base branch
from

Conversation

RenNagasaki
Copy link

Just a small quality of life feature to allow all users to install without prerequisites.

@RenNagasaki RenNagasaki changed the title Install git into conda so user doesn't have to intall globally Install git into conda so user doesn't have to install globally Feb 22, 2025
@erew123
Copy link
Owner

erew123 commented Feb 27, 2025

Silly question, but shouldnt the user have used git by this point to pull the setup files down? If they manually download as a zip, Im pretty sure you cant git pull an update after that, because the versioning history isnt created......

Im not saying there is no reason to have this, just trying to figure the benefit (and my brain isnt in coding mode atm hah)

@RenNagasaki
Copy link
Author

RenNagasaki commented Feb 27, 2025

You're totally correct with the part about getting git updates for the project.
The problem though is that to install the environment, the requirements files get 'installed'. And (I think it was) 2 of them use git for downloading other projects.

requirements_f5tts.txt for example uses this command: "git+https://github.com/SWivid/F5-TTS.git"
Without git installed it fails.

And then the whole install process stops.

You can check this yourself if you just try to install alltalk without an installed git. (Standalone tested only)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants