Fixing Dockerfile change I proposed myself, which doesn't work + Fix for Finetune.py #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to be able to run multiple gpus changing finetune from 127.0.0.1 to 0.0.0.0 so it's accessible.
RenNagasaki
changed the title
Paladinium
reviewed
Feb 26, 2025
|
@RenNagasaki Absolutely fine mixing yourself in. @Paladinium is driving the dockerfile build, I dont see any issues with how it is after the reverted changes, so as long as @Paladinium is happy to pull this in, Im all good with it too. |
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed from Dockerfile: "-m trainer.distribute --script" not working currently since coqui doesn't seem to be able to run multiple gpus.
Changed finetune IP from 127.0.0.1 to 0.0.0.0: Making it accessible. 127.0.0.1 blocks any access from outside the container.
Changed the print behaviour: Error type prints should always be printed for easier pinpointing where the problem is.
@erew123 I hope that's fine that I mix myself in here now aswell? 😆