Fix for: Violation of noParameterWithNullableTypeDeclaration rule identifies itself as "ergebnis.noParameterWithContainerTypeDeclaration" in PHPStan output #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelkiessling
requested review from
ergebnis-bot and
localheinz
as code owners
…ntifies itself as "ergebnis.noParameterWithContainerTypeDeclaration" in PHPStan output - see ergebnis#901
localheinz
force-pushed
the
bugfix/ergebnis-phpstan-rules-901-no-parameter-with-nullable-type-declaration-identifies-itself-incorrectly
branch
from
b773836 to
8538305
Compare
localheinz
approved these changes
Jan 16, 2025
|
Thank you, @manuelkiessling! |
|
Released as |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #902 +/- ##
=========================================
Coverage 98.46% 98.46%
Complexity 201 201
=========================================
Files 24 24
Lines 718 718
=========================================
Hits 707 707
Misses 11 11 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #901.