Fix: Do not report maximum duration for slow tests #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
force-pushed
the
fix/maximum-duration
branch
3 times, most recently
from
957b2c1
to
b5cb5c6
Compare
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Michael Voříšek <[email protected]>
localheinz
force-pushed
the
fix/maximum-duration
branch
from
b5cb5c6
to
6444621
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #450 +/- ##
============================================
- Coverage 69.86% 69.18% -0.69%
+ Complexity 110 109 -1
============================================
Files 26 26
Lines 521 503 -18
============================================
- Hits 364 348 -16
+ Misses 157 155 -2 ☔ View full report in Codecov by Sentry. |
|
I prefer to close this PR in favor of #396. Non-default duration is good to be reported to let the user know that some value like 61 seconds is not too much, as 60 seconds was max. passing duration for example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request
Replaces #379.
/cc @mvorisek