Get confirmed + unconfirmed unspent boxes EP #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskin1
requested changes
Nov 1, 2022
| val ergoTree = addressToErgoTreeHex(address) | ||
| (for { | ||
| nConfirmed <- outputs.countUnspentByErgoTree(ergoTree) | ||
| nUnonfirmed <- uoutputs.sumUnspentByErgoTree(ergoTree) |
There was a problem hiding this comment.
Suggested change
| nUnonfirmed <- uoutputs.sumUnspentByErgoTree(ergoTree) | |
| nUnсonfirmed <- uoutputs.sumUnspentByErgoTree(ergoTree) |
| val ergoTree = addressToErgoTreeHex(address) | ||
| (for { | ||
| nConfirmed <- outputs.countUnspentByErgoTree(ergoTree) | ||
| nUnonfirmed <- uoutputs.sumUnspentByErgoTree(ergoTree) |
There was a problem hiding this comment.
Please look careful at what sumUnspentByErgoTree really does
Comment on lines
399
to
409
| confirmed <- outputs | ||
| .streamUnspentByErgoTree(ergoTree, paging.offset, paging.limit, ord.value) | ||
| .chunkN(serviceSettings.chunkSize) | ||
| .through(toOutputInfo) | ||
| .map(UOutputInfo.fromOutputInfo) | ||
| .to[List] | ||
| unconfirmed <- Stream | ||
| .evalSeq( | ||
| uoutputs | ||
| .getAllUnspentByErgoTree(ergoTree) | ||
| ) |
There was a problem hiding this comment.
So it seems your paging doesn't work as it should here. You retrieve a slice of expected number of confirmed outputs streamUnspentByErgoTree(ergoTree, paging.offset, paging.limit, ord.value) and then concatenate it with unknown number of unconfirmed outputs.
oskin1
reviewed
Nov 11, 2022
Comment on lines
191
to
211
| val q = sql""" | ||
| |select * from ( | ||
| |select distinct on (o.box_id) | ||
| | o.box_id, | ||
| | o.tx_id, | ||
| | o.value, | ||
| | o.creation_height, | ||
| | o.index, | ||
| | o.ergo_tree, | ||
| | o.ergo_tree_template_hash, | ||
| | o.address, | ||
| | o.additional_registers, | ||
| | null | ||
| |from node_u_outputs o | ||
| |left join node_u_inputs i on i.box_id = o.box_id | ||
| |where i.box_id is null and o.ergo_tree = $ergoTree | ||
| |union all | ||
| |select distinct on (o.box_id, o.global_index) | ||
| | o.box_id, | ||
| | o.tx_id, | ||
| | o.value, |
| .in(PathPrefix / "unspent" / "all" / "byAddress" / path[Address]) | ||
| .in(paging(settings.maxEntitiesPerRequest)) | ||
| .in(ordering) | ||
| .out(jsonBody[Items[UOutputInfo]]) |
There was a problem hiding this comment.
Let's not shrink OutputInfo down to UOutputInfo (omitting some fields). I'd suggest adding new coproduct that contains both variants (AnyOutputInfo = OutputInfo | UOutputInfo).
oskin1
approved these changes
Nov 23, 2022
|
may help you and can be used as reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#245