Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0] Fix for downcasting BigInt to other numeric types #774

Merged
merged 2 commits into from
Oct 5, 2024

Conversation

SethDusek
Copy link
Collaborator

For #770. Also fixes upcasting BigInt256 to BigInt256 (previously sigma-rust would accept this on all versions, even though this is 6.0-specific)

Previously this worked unconditionally, even on v4.0 and v5.0
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11177535395

Details

  • 41 of 45 (91.11%) changed or added relevant lines in 3 files are covered.
  • 20 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 79.007%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ergotree-interpreter/src/eval/downcast.rs 32 33 96.97%
ergotree-interpreter/src/eval/upcast.rs 4 5 80.0%
ergotree-ir/src/bigint256.rs 5 7 71.43%
Files with Coverage Reduction New Missed Lines %
ergotree-interpreter/src/eval/upcast.rs 2 77.78%
ergotree-ir/src/serialization/types.rs 8 82.58%
ergotree-interpreter/src/eval/downcast.rs 10 85.42%
Totals Coverage Status
Change from base Build 11146473813: -0.02%
Covered Lines: 10884
Relevant Lines: 13776

💛 - Coveralls

@SethDusek SethDusek requested a review from kushti October 4, 2024 12:20
@SethDusek SethDusek merged commit e56e6fa into develop Oct 5, 2024
13 checks passed
@SethDusek SethDusek deleted the downcast6.0 branch October 7, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants