-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct environment for Template Compiler #977
Conversation
By adding the parameters in the template compile step wont this end up with an ergotree with no ConstantPlaceholders for the parameters? I don't think the SigmaTemplateCompiler can differentiate between normal constants and parameter values. |
… in the compiled expression
@@ -19,6 +18,7 @@ import scala.collection.mutable.ArrayBuffer | |||
*/ | |||
class SigmaTyper(val builder: SigmaBuilder, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ScalaDoc (class args description) is missed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
"""/**/ | ||
|@contract def contractName(low: Int = 0, high: Int) = sigmaProp(low < HEIGHT && HEIGHT < high) && condition | ||
|""".stripMargin | ||
val env: ScriptEnv = Map.empty // no value for "high" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
env is not used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Closes #966
In this PR: