Include copy time on plotman analyze #704
Conversation
Updated: Total time includes Copy time
|
|
||
| # Rename plot. Sample log line: | ||
| # Renamed final file from "/mnt/d1/a4.plot.2.tmp" to "/mnt/d2/a4.plot" | ||
| m = re.search(r'^Renamed final file.*', line) |
There was a problem hiding this comment.
Is this present regardless of what combinations of tmp/tmp2/dst are specified?
There was a problem hiding this comment.
Yes, and if tmp same as dst it will show 0 sec because of simple renaming.
|
I'm a bit hesitant to have total time in analyze mean a different thing than total time in the logs. Any ideas what else would be a good name for the combination? Having total, copy, and combined time would allow the output code to stay more like before but just add the two new bits. Do you have a log you could share that shows the copy time? My most recent logs don't include it. They should have been from 1.1.7. I have tmp the same as dst so there's no copying so it's understandable. |
|
It might be called Summary. I don't have logs for 1.1.7. When I got the first numbers in the Copy Time column I made a decision to switch from separate folders to one for all 😄 |
|
How about we just go literal with |
Closes #673
Added: Copy time column in analyzer
Updated: Total time includes Copy time