…lugin

This prevents a rediculous number of calls to update_repositories
caused by the fact that redmine saves to the repository model for
every commit that it examines.  This patch also prevents multiple
calls to update_repositories when adding groups to the membership
of a project.

You need to migrate plugins to take advantage of new indices:

	rake db:migrate_plugins

This patch should remove all remaining need for recursive calls to update_repositories.
Will log such calls as errors in upcoming major code fix...

The primary "update_repositories" function is now largely self-correcting
against a variety of errors seen in the field.  Also added a bunch of
error checking on functions called-out to the shell.  Among other things,
this code attempts to reconnect the gitolite-admin public key when it
gets deleted (can happen).

Regular use of 'sys/fetch_changesets' will recorrect any errors in the
public key directory and gitolite.conf file. For example, orphan keys
that happen to be left behind in the public key directory will be removed,
missing keys will be added, etc.

One new piece of functionality is the 'recycle_bin' which is used to store
deleted repositories immediately after they are deleted (allowing them
to be recovered for up to 'gitRecycleExpireTime' hours after deletion).

You need to migrate plugins because there are new plugin settings:

    rake db:migrate_plugins

This is not a major issue (or even correctness issue), but will cause
complaints of recursion in the log.

change rakefile to install binary policy (redmine_git.pp) instead of
compiling source policy (redmine_git.te) before every
installation. New rake task added to recompile policy if necessary:

    rake selinux:redmine_git_hosting:build_policy

It is important to remember to migrate_plugin settings, since there
are new settings and one setting has changed a bit (i.e. httpServer
should nolonger include a rails_root path).  Thus, make sure to:

    rake db:migrate_plugins

This commit includes a number of changes.  First and foremost, the
update_repositories() function now handles deletes and repository
moves as well as all other changes.  Consequently, :RESYNC_ALL will be
able to recover from a variety of problems involving movement of
repositories resulting from project parent changes.  Note that changes
in the parent for a subtree of projects works much better than before.

Second, this commit adds new settings which allow (1) redmine-managed
repositories to be focused in a specific subdirectory of the gitolite
repository, (2) allow repositories to be named either hierarchically
(default) or concentrated in a single directory (flat) independent of
project parents, and (3) an extra path parameter which can be added to
the http URL for smart http access of repositories.

Third, added the "access" box at the top of the settings page which
shows explicitly how settings affect access parameters.

Random improvements include (1) rewrite of routes for smart HTTP to
better handle changes in parentage (and avoid need to change routes as
project parents change); (2) changes in settings now immediately
trigger resulting changes in state (before, the settings cache got in
the way); (3) all of the path functions (repository positions, ssh
access, http access) have been concentrated into a small number of
functions at the top of git_hosting.rb, rather than spread throughout
the code; (4) continuing the changes started with the original
performance fixes, cleaned up observer behavior triggered by changes
in project membership and settings.

First, altered views to correct for the fact that (1) TabularFormBuilder
was removed and (2) labelled_tabular_form_for was deprecated.  To allow
this new code to work with pre 1.3.1 versions of Redmine, added an
app/helpers/application_helper.rb which defines the new accepted
helpers if they are not already defined.

Second, made the gitolite_public_keys controller a bit more RESTful in
response to the removal of the generic :controller/:method/:id route.
Note that without these changes, get weird failures around the /my/account
sidebar.  Now, everything happens on the /my/account page: Does not use
separate screen for key edit, and removed the confusion "active" checkbox
on edit (given recent fixes, this is only a weird way to delete key).  Finally,
this code asks for confirmation before deleting a key.  Note that account.rhtml
updated slightly (has password icon now near "change password").

This commit refactors the gitolite-public-key view to (1) remove
MVC violations (i.e. move the DB access into respective controllers,
(2) separate the view/edit functionality into a separate partial so
that (3) it can be called from the user edit screen.  As a result,
the administrator can now look at and edit user's keys (which I have
found is necessary for some clueless users).  The previous commit
would allow someone to view other public keys (but not edit them!); this
commit fixes this flaw.

Also, updated the style of the display to better reflect the 1.3+
style of redmine.  This code is still backward compatible with
earlier versions of redmine.  Also, moved .rhtml => .html.erb in
preparation for Rails 3.0 (rest of Redmine alreday updated)

…ix for access box.

…now reported. Removed extra cruft in error reporting.

use with smart HTTP, even when usernames include illegal characters
such as '@'. For example, usernames such as "John@Doe" => "John%40Doe"
in the URL box.

Fixed some stray colons that broke ChiliProject 3.0 on Ruby 1.9.2-p290.
According to gcymbalski, ChiliProject is 3.0 is now functional.

repository access methods for new repositories (i.e. for daemon, HTTP,
and CIA notification). Finally, added more rake tasks to ease
maintenance (in the :redmine_git_hosting namespace). Update README
with information about these new options and with with new
compatibility information.

Since there are 5 new settings, make sure to migrate plugins again:

    rake db:migrate_plugins RAILS_ENV=xxx

directory, thereby (hopefully) avoiding confusion about this
directory. Give options for making scripts read-only if desired. Small
updates to settings logic to better support this installation flow.

tasks in gitolite.rake as deprecated.

this by changing the access mechanism to automatically construct a
git_repository_extra structure if it is missing.

removed as project and repository permissions change. Also, when
projects are not public, the git-daemon selection box on the
repository page is disabled (to make it clearer that non-public
projects cannot be exported by the git daemon).

Several changes here: (1) if failed to merge changes, try deleting and
recloning before doing something more drastic.  (2) Try to fixup admin
key by using direct cloning of admin repo and pushing of changes via
gl-admin-push; fallback to gl-setup only if gl-admin-push doesn't
exist.  (3) When reinstalling admin key, try to keep admin key name
from conf file (if exists) or keydir (if there is a matching key to
remine's key).  (4) Finally make sure to remove any keys from keydir
that match redmine's key before reinstalling key -- to avoid name
conflicts on access.

of project should have triggered removal of user's keys from the
keydir.

This problem likely introduced by earlier fix to mirror error reporting.

labelled_form_for and labelled_remote_form_for: do not do so if
lib/tabular_form_builder.rb undefined!

Grabbed fix from Eric Bishop (who received via email by Davil Vallejo).

Changes in this release:

1) Compatibility with Redmine 1.1-stable
2) Compatibility with Ruby 1.9 (really just some syntax fixes)
3) Better configurability, including ability to set /bin and /tmp paths.
   Better scripts to aid in installation.  Updated instructions in README.
4) Variety of bug fixes: mirrors work better, git-daemon support, better
   error recovery from lost gitolite admin key, handling of '@' in username
   for smart-http access.

gitolite administrative key.

1) Allow the csrf_meta_tag() in popup.erb to fail gracefully, since
version skew in the Rails installation on some Debian platforms causes
this operation to fail (complaining about a missing String#html_safe).

2) Also in popup.erb, if helper function "javascript_heads" not
defined (it isn't in Redmine 1.1), simply use "javascript_include_tag"
to get javascript included.

Now, clone_or_pull_gitolite_admin() will refuse to merge in existing
changes (which could involve deletes from tmpwatch).  Instead, it will
recognize the unmerged changes and simply delete and reclone.

Note that such unmerged changes will not exist unless something bad
has happened.  Cleanup may require executing a RESYNC_ALL operation
(i.e. fetch_changesets).

This is a bugfix release.  Changes in this release:

1) Fixed missed case for Redmine 1.1 compatibility (mirror functionality)
2) Fixed bad interaction between cron cleanup of /tmp and access to
   gitolite-admin repository in /tmp.  Behavior could cause user
   keys to appear to be deleted, even though they remain in the redmine
   database.

…tions.

1) Delete keys from gitolite.conf when removing users from project ACL.

Not sure how this case never noticed before.  Bug happens because
user delete => update_repositories(:delete), which didn't go through
and rationalize the gitolite.conf.  Removed optimization to fix.

2) When deleting user, execute use :delete flag to remove keys keydir.

When a project is archived, we remove its keys from gitolite.conf (and
possibly from the keydir if this project is the only one that uses
these keys).  We also remove the git_daemon access and mark the gitolite.conf
entry with a dummy key: "redmine_archived_project".

We leave the repository in the gitolite repo.

Conflicts:
	init.rb

This is a merge of suggested changes from Greg Thornton
<[email protected]> to support invoking post-update URLs.
Conflict was from the fact that I moved modifications of Project into
project_patch.rb (since there are now a number of patches to
project.rb now).

Fix syntax error in gitolite_hoooks_controller.rb, turn payload into json.
Addition of changes to missing non-english locals.

existing hooks if they don't match our hooks. Default value == true.

Now, offer ability to push upstream without full mirroring
(i.e. without the '--mirror' argument).  Added ability to force
updates or allow fast forward updates.  Further, can choose to
push references with an explicit reference specification (supports
full syntax, allowing one to push to a branch with a different remote
name than the local name.

This was due to a bug in ruby 1.8.7's Net::HTTP::Post.set_form_data.

New parameters gitConfigFile and gitConfigHasAdminKey set this
feature.  The gitConfigFile is relative to the conf/ directory.  The
gitConfigHasAdminKey parameter states whether or not the plugin will
maintain the administrative key in the gitConfigFile (forced to true
for default config file of gitolite.conf.

… 3.0.

Reorganized patches to put all of the patch-specific includes
and patching operations into the individual patch files.  This leaves
only a need for explicitly loading each of the patch files, which
is now done with a require_dependency inside a loop...

for actual command (to prevent shell expansion of bad characters).

Deployment credentials are constructed on the repository settings page
for a repository and consist of combinations of public keys and
permissions (currently either "R" or "RW+".  The public keys for
deployment credentials are owned by users with 'manager' permissions.
The administrator can modify (add/update/delete) all deployment
credentials.

Also included with this commit is a functioning validation on the
public key display window (this wasn't working originally).

We now treat this case exactly the same as an archived
project/repository.  Before, it was handled inconsistently.  Three
changes:

1) When a repository module is disabled/enabled through settings page
   call update_repositories to update state.  A disabling of the
   repository module will call update_repositories with :archive.

2) Existing repositories will be left alone and marked with a dummy
   redmine key of "redmine_disabled_project".  Reenabling of the
   repository module will restore project and keys to accessibility.

3) When removing redmine keys from a gitolite.conf entry, don't report
   in the log unless removing real readmine keys.  This avoids a weird
   circumstance in which every fetch_changesets operation reports that
   it is deleting redmine keys (caused when repo entry exists but the
   "delete_repositories" flag is disabled at the time that the repo is
   deleted.  This fix is entirely about removing confusing messages
   from the log.

This is a feature release.  It includes:

     1) Post-Receive URLS
     2) Updated Mirror Functionality
     3) Deployment Credentials
     4) Support for secondary gitolite configuration file

It also includes a series of bug fixes.  See release notes at:
https://github.com/kubitron/redmine_git_hosting/wiki/_history

…fixes.

Also, check for repository_identifier uniqueness when migrating.

…=> 0.5.0x.

…ed_cia

This is a feature release which provides compatibility with Redmine 1.4.

It also includes a few bug fixes.  See release notes at:
https://github.com/kubitron/redmine_git_hosting/wiki/Release-Notes

…ither array of strings or symbols depending on version of Ruby.