Skip to content

Commit

Permalink
rename file ponysay to ponysay.py
Browse files Browse the repository at this point in the history
  • Loading branch information
@maandree
maandree committed Sep 29, 2012
1 parent 46544c3 commit 04aae4a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
0 ponysay → ponysay.py
View file
File renamed without changes.
2 changes: 1 addition & 1 deletion setup.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ def compress(source, destination, ext):
(fileout, filein) = (None, None)
try:
fileout = open('ponysay.install', 'wb+')
filein = open('ponysay', 'rb')
filein = open('ponysay.py', 'rb')
data = filein.read().decode('utf-8', 'replace')

if '#!/usr/bin/env python3' in data:
Expand Down

4 comments on commit 04aae4a

@JotaRandom
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and ponythink, need rename too or not???

@maandree
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a ponythink file, that link is created by the build system.
This rename is because we renamed the source file ponysay to ponysay.py,
the installed filenames have not been modified.

@JotaRandom
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read about the emacs and the python that you talk with svenstaro and I think that (probably erroneous) that the ponythink simlink need the .py for the same reason as now ponysay have them, you say ponythink point to ponysay

@maandree
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

source files: ponysay.py
installed files: ponysay, ponythink→ponysay

At the line filein = open('ponysay.py', 'rb')
The builder reads the source file ponysay.py, and creates the file ponysay.install (the line above).
Then the installer copies the file ponysay.install to ponysay and creates the symlink ponythink.

The installed files are named without .py, because otherwise you would have to run the command
ponysay.py instead of ponysay, and ponythink.py instead of ponythink.

But the source file (ponysay.py) need python3 instead of python in its shebang, and for Emacs
(and probably editors too) .py is then needed for highlighting.

There is no ponythink in the source, where the only ponysay.py is located, so there should not
be any ponythink.py file.

Please sign in to comment.