Skip to content

Commit

Permalink
Remove the pony after installation because it is a fairly ugly line a…
Browse files Browse the repository at this point in the history 
…nd breaks in chroots that don't have a proper terminal attached. This could be fixed but frankly let's just keep it this way.
  • Loading branch information
Sven-Hendrik Haase committed Aug 23, 2012
1 parent ccee09b commit 2fbf0a3
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions configure
View file
Original file line number Diff line number Diff line change
Expand Up @@ -307,9 +307,6 @@ function makeMakefile()
'| |___/ |___/ |\\n'\\
'\\\\--------------------------------------------------/'
EOF
echo -en '\t' ; echo '@echo dummy | ./ponysay.install -f ./`if [[ "$$TERM" = "linux" ]]; then echo ttyponies; else echo ponies; fi`/pinkiecannon.pony | tail --lines=30 ; echo -e \\n'
echo

echo 'uninstall:'
echo -en '\t' ; echo 'if [ -d "$/var/cache/ponysay" ]; then rm -rf "$/var/cache/ponysay"; fi'
for old in $installedDirs; do
Expand Down

3 comments on commit 2fbf0a3

@maandree
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it modifies your TTY palette if you have a custom one and do not let ponysay know about it.

Now with the lastest version of ponysay it can done with just ponysay -f pinkiecannon <<EOF .....
Should we do that and add a check that $$TERM is either xterm or xterm-256color, and maybe
change the text to »Welcome to the herd!»?

I have no clue why a used downloaded files when at the end of the installtion when everything is installed.
Of cause $$PATH needs the bin directory in case it is not there.

@svenstaro
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why $$TERM actually? What does the extra $ do? And also checking for xterm and xterm-256color might be sensible but screen and screen-256color are at least also terminals to check for. I don't know how many other there are that have their own identifier. rxvt-unicode is rxvt-unicode-256color, for instance. I don't know what the best way to catch them all would be.

@maandree
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extra $ make it expand in bash instead of in make. (every line in make is a bash command).

There are many terminals that does not support ponysay, so I think it is best just to check for,
xterm (and maybe urxvt). It is not just colouring that is an use, incompatibility with block elements
are more common. We can also check that stdout is a terminal.

Please sign in to comment.