Improve completion for bash

[williamthome]

This PR improves the completion for bash.

Currently the improvements are:

• Profiles completion: typing rebar3 as <tab> gives a list of the rebar,config profiles, same for rebar3 clean --project/-p <tab>

Any tips or comments about this are welcome.

Note: For now I will do this for bash. Maybe in the future for fish and zsh.

[ferd]

This is good stuff. I think there a few small things to be worried about, but they're probably not gonna be a problem aside from the profiles functionality.

[ferd]

this can break whenever using periods in content. For example:

{profiles, [{
   {test, [{relx, [{sys_config, "./config/test.sys.config"},
   ...
}]}.

This will break on the first profile because of the period.

[williamthome]

Can you try this updated regex?
(?s){profiles,\s*(\r\n)*\n*\r*\[\s*(\r\n)*\n*\r*.*?(?<=\s*(\r\n)*\n*\r*\}\s*(\r\n)*\n*\r*\.)

[ferd]

→ cat rebar.config| grep -oPz '(?s){profiles,\s*(\r\n)*\n*\r*\[\s*(\r\n)*\n*\r*.*?(?<=\s*(\r\n)*\n*\r*\}\s*(\r\n)*\n*\r*\.)'
grep: lookbehind assertion is not fixed length

[williamthome]

I think it's fixed now. Can you try again, @ferd?

$ cat rebar.config | grep -oPz '(?s)(?:{\s*profiles\s*,\s*(\r\n)*\n*\r*\[).*?(?:\s*(\r\n)*\n*\r*}\s*(\r\n)*\n*\r*\.)'

I also refactored to a more generic/reusable code.
There is an issue with comments. This regex does not ignore them. I will take a look at this.

[williamthome]

The comments issue is fixed. Here is the complete command:

cat rebar.config \
| grep -v '\s*%.*' \
| grep -oPz "(?s)(?:{\s*profiles\s*,\s*(\r\n)*\n*\r*\[).*?(?:\s*(\r\n)*\n*\r*}\s*(\r\n)*\n*\r*\.)" \
| tr -d '\0' \
| tr -d '\n' \
| grep -oPz '(?s)(?<=\[).*(?=\])' \
| tr -d '\0' \
| sed -e 's/^[[:space:]]*//'

[ferd]

Yep I think that works! Thanks for updating this, much appreciated!

[williamthome]

Yep I think that works! Thanks for updating this, much appreciated!

Thanks, @ferd! I will do some changes to add more completions, for example to rebar3 unlock <packagename> command, where the <packagename> will be suggested. I will come back when having some news.

[williamthome]

I am closing this PR in favor of #2858.
Excellent job, @MarkoMin!