Remove using, todo, magic number

erwinpan1 · Feb 12, 2024 · 5edba02 · 5edba02
1 parent 13aa22e
commit 5edba02
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/examples/chef/common/clusters/media-input/MediaInputManager.cpp b/examples/chef/common/clusters/media-input/MediaInputManager.cpp
@@ -27,7 +27,7 @@ MediaInputManager::MediaInputManager()
 {
     mCurrentInput = 1;
 
-    for (int i = 1; i < 3; ++i)
+    for (int i = 1; i < mTotalInput; ++i)
     {
         InputInfoType inputInfo;
         inputInfo.description = chip::CharSpan::fromCharString("High-Definition Multimedia Interface");
@@ -40,7 +40,6 @@ MediaInputManager::MediaInputManager()
 
 CHIP_ERROR MediaInputManager::HandleGetInputList(chip::app::AttributeValueEncoder & aEncoder)
 {
-    // TODO: Insert code here
     return aEncoder.EncodeList([this](const auto & encoder) -> CHIP_ERROR {
         for (auto const & inputInfo : this->mInputs)
         {

diff --git a/examples/chef/common/clusters/media-input/MediaInputManager.h b/examples/chef/common/clusters/media-input/MediaInputManager.h
@@ -22,10 +22,9 @@
 #include <app/clusters/media-input-server/media-input-server.h>
 #include <vector>
 
-using InputInfoType = chip::app::Clusters::MediaInput::Structs::InputInfoStruct::Type;
-
 class MediaInputManager : public chip::app::Clusters::MediaInput::Delegate
 {
+using InputInfoType = chip::app::Clusters::MediaInput::Structs::InputInfoStruct::Type;
 public:
     MediaInputManager();
 
@@ -42,4 +41,7 @@ class MediaInputManager : public chip::app::Clusters::MediaInput::Delegate
     std::vector<chip::app::Clusters::MediaInput::Structs::InputInfoStruct::Type> mInputs;
     // Magic numbers are here on purpose, please allocate memory
     char mCharDataBuffer[10][32];
+
+private:
+    static constexpr int mTotalInput              = 3;
 };