Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve compatibility with + add test for DOMException #3

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improve compatibility with + add test for DOMException #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe4d3cf
Improve compatibility with + add test for DOMException
lionel-rowe Nov 13, 2024
13c3634
Revert to closer to previous logic; safer domExceptionClonable
lionel-rowe Nov 13, 2024
4729c92
Check instanceof instead of toString for DOMException
lionel-rowe Nov 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion implementation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,32 @@ var $toString = callBound('Object.prototype.toString');
var stackDesc = gOPD($Error.prototype, 'stack');
var stackGetter = stackDesc && stackDesc.get && callBind(stackDesc.get);

var domExceptionClonable = !!(
$structuredClone
&& typeof DOMException === 'function'
&& $structuredClone(new DOMException()) instanceof $Error
);

module.exports = function isError(arg) {
if (!arg || (typeof arg !== 'object' && typeof arg !== 'function')) {
ljharb marked this conversation as resolved.
Show resolved Hide resolved
return false; // step 1
}

if (typeof DOMException === 'function' && arg instanceof DOMException) {
return true;
}

if (isNativeError) { // node 10+
return isNativeError(arg);
}

if ($structuredClone) {
try {
return $structuredClone(arg) instanceof $Error;
if ($structuredClone(arg) instanceof $Error) {
return true;
} else if (domExceptionClonable) {
return false;
}
} catch (e) {
return false;
}
Expand Down
3 changes: 2 additions & 1 deletion test/tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ module.exports = function (isError, t) {
new URIError(),
new EvalError(),
typeof AggregateError === 'function' ? new AggregateError([]) : [],
typeof SuppressedError === 'function' ? new SuppressedError() : []
typeof SuppressedError === 'function' ? new SuppressedError() : [],
typeof DOMException === 'function' ? new DOMException() : []
), function (error) {
st.equal(isError(error), true, inspect(error) + ' is an Error object');
});
Expand Down