Make sure Date.parse is not enumerable.

Fixes #310.
es-shims · Jun 17, 2015 · ab9ff98 · ab9ff98
1 parent a91d34e
commit ab9ff98
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/es5-shim.js b/es5-shim.js
@@ -1029,7 +1029,7 @@ if (!Date.parse || doesNotParseY2KNewYear || acceptsInvalidDates || !supportsExt
         }, true);
 
         // Upgrade Date.parse to handle simplified ISO 8601 strings
-        DateShim.parse = function parse(string) {
+        var parseShim = function parse(string) {
             var match = isoDateExpression.exec(string);
             if (match) {
                 // parse months, days, hours, minutes, seconds, and milliseconds
@@ -1084,6 +1084,7 @@ if (!Date.parse || doesNotParseY2KNewYear || acceptsInvalidDates || !supportsExt
             }
             return NativeDate.parse.apply(this, arguments);
         };
+        defineProperties(DateShim, { parse: parseShim });
 
         return DateShim;
     }(Date));

diff --git a/tests/spec/s-date.js b/tests/spec/s-date.js
@@ -52,6 +52,10 @@ describe('Date', function () {
     describe('parse', function () {
         // TODO: Write the rest of the test.
 
+        ifSupportsDescriptorsIt('is not enumerable', function () {
+          expect(Object.getOwnPropertyDescriptor(Date, 'parse').enumerable).toBe(false);
+        });
+
         it('should support extended years', function () {
             expect(Date.parse('0001-01-01T00:00:00Z')).toBe(-62135596800000);
             expect(Date.parse('+275760-09-13T00:00:00.000Z')).toBe(8.64e15);