365 implement inference execution with pytest #384
Conversation
…y point in time independent of the other inputs
…orrectly and still accessible
…y point in time independent of the other inputs
…orrectly and still accessible
…-coverage-to-the-existing-linear-layer' into 360-add-the-ghdl-simulation-test-coverage-to-the-existing-linear-layer
…will be used in the future to do system tests
…sb-protocol-from-the-runtime' into 361-add-a-system-testend-to-end-for-the-existing-linear-layer
Signed-off-by: Leo Buron <[email protected]>
Signed-off-by: Leo Buron <[email protected]>
…ion-with-pytest # Conflicts: # elasticai/creator/nn/fixed_point/conv1d/layer/batch_normed_conv1d.py # elasticai/creator/nn/fixed_point/conv1d/layer/conv1d.py # elasticai/creator/nn/fixed_point/linear/layer/batch_normed_linear.py # elasticai/creator/nn/fixed_point/linear/layer/linear.py
…with-skeleton-v2' into 365-implement-inference-execution-with-pytest # Conflicts: # elasticai/creator/vhdl/system_integrations/firmware_env5_test.py # elasticai/creator/vhdl/system_integrations/skeleton/network_skeleton_v2.tpl.vhd
Signed-off-by: Leo Buron <[email protected]>
Signed-off-by: Leo Buron <[email protected]>
Signed-off-by: Leo Buron <[email protected]>
Signed-off-by: Leo Buron <[email protected]>
Signed-off-by: Leo Buron <[email protected]>
LeoBuron
added
documentation
elasticai/creator/vhdl/system_integrations/skeleton/network_skeleton_v2.tpl.vhd
Outdated
Show resolved
Hide resolved
elasticai/creator/vhdl/system_integrations/skeleton/network_skeleton_v2.tpl.vhd
Outdated
Show resolved
Hide resolved
pyproject.toml
Outdated
| @@ -29,6 +29,7 @@ impulse = "^1.0" | |||
| pylint = "^2.16.2" | |||
| pytest = "^7.2.2" | |||
| setuptools = "^67.5.1" | |||
| elasticai-runtime-env5 = {git = "https://github.com/es-ude/elastic-ai.runtime.enV5.git", rev = "develop"} | |||
There was a problem hiding this comment.
Do we want to switch runtime version automatically as it gets updated or do we want to switch manually by changing the commit hash or version tag here? The later case seems more safe to me.
There was a problem hiding this comment.
On one hand I agree with you. On the other I think it would make sense to automatically update to develop revision in the runtime, so we can test their newest features. But maybe safety is more important
There was a problem hiding this comment.
From experience I strongly favor safety over convenience here
There was a problem hiding this comment.
Fixed the git revision.
|
A lot of cool stuff. Thanks @LeoBuron. Got a few change requests and a few questions/fyis. Almost forgot... unit tests should pass, obviously. |
…falling edge clock
|
@glencoe I pushed the new code. I fixed the unittest errors. |
…velop branch to specific commit
Added inference of linear layer as a system test with enV5 Rev2 Hardware