refactor(flash): integrate cexception into pac193x library #293
Conversation
# Conflicts: # test/unit/UnittestPac193x.c
BREAKING CHANGE: - removed `publishLong` from public header - removed `free` calls for user allocated memory
BREAKING CHANGE: change interface name
|
Somehow I broke something. For some reason commits that have nothing to do with this branch, are now listed in it. I will stop working on this for now, as to not break anything. Important: I forgot to add the breaking change flag to my initial commit. Rebase doesn't work. |
So what's the state on this one now? Have you been able to fix the problems you were mentioning? Is this PR ready for review? |
|
No I have not been able to fix this yet. |
|
closed because of unclear git history |
src/sensor/pac193x/include/Pac193x.h
Outdated
| */ | ||
| pac193xErrorCode_t pac193xGetSensorInfo(pac193xSensorConfiguration_t sensor, | ||
| pac193xSensorId_t *info); | ||
| void pac193xGetSensorInfo(pac193xSensorConfiguration_t sensor, pac193xSensorId_t *info); |
There was a problem hiding this comment.
turn [out] params into return values
There was a problem hiding this comment.
I checked the functions again. They return the sensor info through the info pointer, which is passed to the function.
So AFAIK there is no return value needed, right?
There was a problem hiding this comment.
The idea is for the function to return the pac193xSensorId_t by value as in
//...
pac193xSensorId_t info;
get_info(&info);
//... do more stuff
return info;
}
src/sensor/pac193x/include/Pac193x.h
Outdated
| pac193xChannel_t channel, | ||
| pac193xValueToMeasure_t valueToMeasure, | ||
| float *value); | ||
| void pac193xGetMeasurementForChannel(pac193xSensorConfiguration_t sensor, pac193xChannel_t channel, |
- make sensorconfig const - remove unnecessary pointers - change return values - update documentation BREAKING CHANGE: Integration of CException
# Conflicts: # src/sensor/pac193x/Pac193x.c # src/sensor/pac193x/include/Pac193x.h
Integrate CException into pac193x library