-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cmake): fix custom targets #313
Draft
glencoe
wants to merge
32
commits into
develop
Choose a base branch
from
fix-custom-cmake-targets
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
glencoe
commented
Oct 25, 2024
•
edited by HerrCooker
Loading
edited by HerrCooker
- Overhaul cmake scripts
- Adjust unit tests
- Adjust hw tests
- Adjust git workflows
PandiasChild
approved these changes
Oct 25, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
4 tasks
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
Alright @PandiasChild and @HerrCooker time for one of you two to take over. I almost finished the sensor hardware tests, but i had trouble with the Adxl stuff, which is commented out right now. You can use interface libraries to keep the build definitions more manageable, e.g. add_library(_HWTestLibForPac139x INTERFACE)
target_link_libraries( _HWTestLibForPac139x INTERFACE
Common
Pico::pico_stdlib
Pico::pico_stdio_usb
Pico::pico_bootrom
Pico::pico_time
I2c
EnV5HwConfiguration
Pac193x
)
add_executable(hardware-test_pac193x HardwaretestPac193x.c)
target_link_libraries(hardware-test_pac193x _HWTestLibForPac139x)
create_enV5_executable(hardware-test_pac193x)
add_executable(hardware-test_pac193x_stream HardwaretestPac193xAccumulator.c)
target_link_libraries(hardware-test_pac193x_stream _HWTestLibForPac139x)
create_enV5_executable(hardware-test_pac193x_stream) |
glencoe
force-pushed
the
fix-custom-cmake-targets
branch
2 times, most recently
from
October 29, 2024 16:58
230bc57
to
629b239
Compare
- Adxl345b target won't compile on MacOS - More hardware tests need to have their build config adjusted to the new cmake style - unit tests are completely converted - also adds new run configurations for ide
glencoe
force-pushed
the
fix-custom-cmake-targets
branch
from
October 29, 2024 17:16
629b239
to
9969e45
Compare
…ix-custom-cmake-targets # Conflicts: # src/fpga/stub/stub_defs.h
* move Time.h to hal subfolder to avoid conflicts with picos time.h on case-sensitive platforms * change scripts to more idiomatic cmake style
- node is stuck on SPI init (i.e. HardwareTestFlash) - node is stuck on ESP init (i.e. HardwareTestConfigureViaHTTP)
- issue in hw tests remains. seems like either something with UART or freeRTOS is not working properly --> sleep in ESPinit does not return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.