Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmake): fix custom targets #313

Draft
wants to merge 32 commits into
base: develop
Choose a base branch
from
Draft

Conversation

glencoe
Copy link
Contributor

@glencoe glencoe commented Oct 25, 2024

  • Overhaul cmake scripts
  • Adjust unit tests
  • Adjust hw tests
  • Adjust git workflows

@glencoe glencoe marked this pull request as draft October 29, 2024 09:04
@glencoe

This comment was marked as off-topic.

@glencoe glencoe linked an issue Oct 29, 2024 that may be closed by this pull request
4 tasks
@glencoe

This comment was marked as duplicate.

@glencoe

This comment was marked as duplicate.

@glencoe

This comment was marked as duplicate.

@glencoe glencoe removed the request for review from PandiasChild October 29, 2024 16:42
@glencoe
Copy link
Contributor Author

glencoe commented Oct 29, 2024

Alright @PandiasChild and @HerrCooker time for one of you two to take over. I almost finished the sensor hardware tests, but i had trouble with the Adxl stuff, which is commented out right now.

You can use interface libraries to keep the build definitions more manageable, e.g.

add_library(_HWTestLibForPac139x INTERFACE)
target_link_libraries( _HWTestLibForPac139x INTERFACE
        Common
        Pico::pico_stdlib
        Pico::pico_stdio_usb
        Pico::pico_bootrom
        Pico::pico_time
        I2c
        EnV5HwConfiguration
        Pac193x
)

add_executable(hardware-test_pac193x HardwaretestPac193x.c)
target_link_libraries(hardware-test_pac193x _HWTestLibForPac139x)
create_enV5_executable(hardware-test_pac193x)


add_executable(hardware-test_pac193x_stream HardwaretestPac193xAccumulator.c)
target_link_libraries(hardware-test_pac193x_stream _HWTestLibForPac139x)
create_enV5_executable(hardware-test_pac193x_stream)

@glencoe glencoe force-pushed the fix-custom-cmake-targets branch 2 times, most recently from 230bc57 to 629b239 Compare October 29, 2024 16:58
glencoe and others added 6 commits October 29, 2024 18:01
- Adxl345b target won't compile on MacOS
- More hardware tests need to have their build config
  adjusted to the new cmake style
- unit tests are completely converted
- also adds new run configurations for ide
Jan and others added 17 commits November 8, 2024 15:11
…ix-custom-cmake-targets

# Conflicts:
#	src/fpga/stub/stub_defs.h
* move Time.h to hal subfolder to avoid
  conflicts with picos time.h on
  case-sensitive platforms

* change scripts to more idiomatic cmake
  style
- node is stuck on SPI init (i.e. HardwareTestFlash)
- node is stuck on ESP init (i.e. HardwareTestConfigureViaHTTP)
- issue in hw tests remains. seems like either something with UART or freeRTOS is not working properly
  --> sleep in ESPinit does not return
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement new custom targets in CMAKE
3 participants