Tweak notableDonations schema

esamarathon · Feb 19, 2024 · 469492c · 469492c
1 parent 4a01a5f
commit 469492c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/schemas/notableDonations.json b/schemas/notableDonations.json
@@ -1,6 +1,7 @@
 {
   "$schema": "http://json-schema.org/draft-07/schema",
   "type": "array",
+  "$comment": "Some of this schema is actually wrong, and was modified due to another application sending incorrect data!",
   "items": {
     "type": "object",
     "additionalProperties": false,
@@ -21,7 +22,14 @@
         "type": "string"
       },
       "comment": {
-        "type": "string"
+        "oneOf": [
+          {
+            "type": "string"
+          },
+          {
+            "type": "null"
+          }
+        ]
       },
       "time_received": {
         "type": "string"
@@ -32,9 +40,7 @@
       "_id",
       "donor_visiblename",
       "amount",
-      "comment_state",
-      "comment",
-      "time_received"
+      "comment"
     ]
   },
   "default": []

diff --git a/src/types/schemas/notableDonations.d.ts b/src/types/schemas/notableDonations.d.ts
@@ -10,7 +10,7 @@ export type NotableDonations = {
 	_id: number;
 	donor_visiblename: string;
 	amount: number;
-	comment_state: string;
-	comment: string;
-	time_received: string;
+	comment_state?: string;
+	comment: string | null;
+	time_received?: string;
 }[];