Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize massive if-statement in companion extension #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

duncte123
Copy link
Contributor

@duncte123 duncte123 commented May 9, 2024

The "safety wait" was never awaited for the video player, I assumed that this was a bug and patched this as well.

Pros:

  • Easier to read
  • Easier to maintain
  • It will run slightly faster (but we're using nodejs so performance is RIP either way)

Cons:

  • You'll have to make a new file for each action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant