New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize massive if-statement in companion extension #97

Open

duncte123 wants to merge 1 commit into master from companion-cleanup

Contributor

duncte123 commented May 9, 2024 •

edited

Loading

The "safety wait" was never awaited for the video player, I assumed that this was a bug and patched this as well.

Pros:

Easier to read
Easier to maintain
It will run slightly faster (but we're using nodejs so performance is RIP either way)

Cons:

You'll have to make a new file for each action


          Optimize massive if-statement

79a7d14

duncte123 requested a review from zoton2

May 9, 2024 07:49

duncte123 self-assigned this

duncte123 mentioned this pull request

Streamdeck plus support BSGmarathon/esa-layouts#20

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet