Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes plus compatibility with OpenSesame 4.0 #175

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

smathot
Copy link
Contributor

@smathot smathot commented Oct 10, 2023

This PR refactors the plugins to be compatible with OpenSesame 4.0. It also fixes in the osscreen class.

@esdalmaijer
Copy link
Owner

esdalmaijer commented Oct 10, 2023

Fab, thanks! I just have two questions:

  1. Could you check and clarify the version number? It's listed as 0.8.7 in pygaze/init.py, but as 0.8.0a1 in pyproject.toml. I'm OK to jump to 0.8.0, and imagine the 0.8.7 is a typo?

  2. This explicitly switches us from setup.py to poetry for packaging. I still package through the former, so I'm not super keen on deleting the setup files. Is there a need for a switch to poetry, or does it come with some benefit?

@smathot
Copy link
Contributor Author

smathot commented Oct 11, 2023

Yes sorry it's a bit messy because some of the commits go back a few months. I apparently forgot to submit a PR at the time.

Could you check and clarify the version number? It's listed as 0.8.7 in pygaze/init.py, but as 0.8.0a1 in pyproject.toml. I'm OK to jump to 0.8.0, and imagine the 0.8.7 is a typo?

It should be 0.8.7. I updated pyproject.toml, which I forgot initially.

This explicitly switches us from setup.py to poetry for packaging. I still package through the former, so I'm not super keen on deleting the setup files. Is there a need for a switch to poetry, or does it come with some benefit?

You can have them both if you want. Using pyproject.toml is much easier though, and is also the recommended packaging method, which is why I switched for all projects. But there's no reason why you couldn't have a setup.py alongside a pyproject.toml. setup.py would need to updated for the new plugin structure though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants