Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(pr-check): add tsv output verification #58

Merged
merged 13 commits into from
Dec 10, 2024
Merged

ci(pr-check): add tsv output verification #58

merged 13 commits into from
Dec 10, 2024

Conversation

cmdoret
Copy link
Collaborator

@cmdoret cmdoret commented Dec 9, 2024

This PR adds:

  • a dummy edf file for tests
  • a check in pr-check that runs the submitted algorithm image on the dummy file and verifies the header of the output tsv file

Currently, it assumes thath the output header exactly matches:

onset	duration	eventType	confidence	channels	dateTime	recordingDuration

I am not sure this is a valid assumption.

@cmdoret cmdoret requested a review from danjjl December 9, 2024 16:01
@cmdoret cmdoret self-assigned this Dec 9, 2024
@cmdoret cmdoret linked an issue Dec 9, 2024 that may be closed by this pull request
2 tasks
@danjjl danjjl force-pushed the ci/pr-check-output branch from e49dd2a to 6c0f836 Compare December 10, 2024 13:29
@danjjl danjjl merged commit d307e7d into main Dec 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate algorithm image produces a valid TSV
2 participants