Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gradualizer to ci #4

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

aleklisi
Copy link
Contributor

@aleklisi aleklisi commented Oct 4, 2019

This PR adds Gradualizer to CI build.
I'd like to try it here before trying it on MongooseIM.

@@ -15,3 +15,7 @@
{dev_mode, false},
{include_src, false}
]}.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'd really need here to have a

{gradualizer_opts, [{print_file, module}]}.

Otherwise, as you can see on the current Travis build, it raises error but it doesn't say in which file, which is pretty much confusing xD

@@ -9,34 +9,34 @@
1},
{<<"bbmustache">>,{pkg,<<"bbmustache">>,<<"1.6.1">>},1},
{<<"bear">>,
{git,"git://github.com/boundary/bear.git",
{git,"https://github.com/boundary/bear.git",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uff, no, this one, like all the ones in this file, are I think a by-product of your computer maybe connecting to github through https and not through ssh. I don't think we need to change that.

Also, there's no new field for Gradualizer in your rebar.lock, how comes? 🤔

@@ -18,6 +19,7 @@ install: rebar3 compile
script:
- rebar3 xref
- rebar3 dialyzer
- rebar3 gradualizer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we'd need this one in Travis's allow_failures block, like Gradualizer's team themselves have here: https://github.com/josefs/Gradualizer/blob/97e8a9363fb21538c4a7223278ab59499ca2be19/.travis.yml#L9

I think that we could change quite a bit this travis.yml actually, to something like

sudo: false

language: erlang
otp_release:
  - 22.1
  - 21.3

branches:
  only:
    - master
    - /BUILD.*/

addons:
  apt:
    packages:
      - libexpat1-dev

install: rebar3 compile
script:
  - rebar3 xref
  - rebar3 dialyzer

matrix:
  allow_failures:
    - script: rebar3 gradualizer

cache:
  directories:
    - $HOME/.cache/rebar3

@@ -15,3 +15,7 @@
{dev_mode, false},
{include_src, false}
]}.

{plugins, [
{gradualizer, {git, "https://github.com/aleklisi/Gradualizer", {branch, "master"}}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I'd definitely go for the original josefs repo instead of your fork, I don't know how much trouble you might have at keeping your up-to-date. They just pushed a fix for that OTP22 problem you were having 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants