Update summarise-ct-results #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcusfelis
changed the title
chrzaszcz
reviewed
Aug 27, 2024
test/hook_SUITE.erl
Outdated
| "No test groups were executed successfully", | ||
| "Failing the test due to failed rerun groups", | ||
| "Failing the test due to failed test cases", | ||
| "CODE=53"] = summarise_results(), |
There was a problem hiding this comment.
Why is the code 53 even though CT results above show lower numbers?
There was a problem hiding this comment.
Oh, it is erlang:halt(100405), but error code overflows.
1> erlang:halt(100405).
exits
echo $?
53
test/hook_SUITE.erl
Outdated
| " 0 tests eventually passed", | ||
| " 0 tests with end_per_testcase failed", | ||
| " 6 tests passed", | ||
| " 3 tests failed"," 0 tests skipped by user", |
test/hook_SUITE.erl
Outdated
| " 3 tests eventually passed", | ||
| " 0 tests with end_per_testcase failed", | ||
| " 9 tests passed", | ||
| " 3 tests failed"," 0 tests skipped by user", |
MIM repo would have to execute |
arcusfelis
force-pushed
the
summarise-ct-results-with-end-per-testcase-failed
branch
from
d694eb1
to
8e39acd
Compare
chrzaszcz
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After analyzing history, it looks like the script also belongs to the repo and could be tested with tests.