Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix require-meta-schema-description rule crash #496

Closed
wants to merge 1 commit into from
Closed

fix: fix require-meta-schema-description rule crash #496

wants to merge 1 commit into from

Conversation

azat-io
Copy link
Contributor

@azat-io azat-io commented Nov 17, 2024

The rule crashes when the rest operator is used in the rule's metadata.

Oops! Something went wrong! :(

ESLint: 9.15.0

TypeError: Error while loading rule 'eslint-plugin/require-meta-schema-description': Cannot read properties of undefined (reading 'type')
Occurred while linting /Users/azat/Developer/eslint-plugin-perfectionist/rules/sort-classes.ts
    at checkSchemaElement (/Users/azat/Developer/eslint-plugin-perfectionist/node_modules/.pnpm/[email protected][email protected][email protected]_/node_modules/eslint-plugin-eslint-plugin/lib/rules/require-meta-schema-description.js:67:15)
    at checkSchemaElement (/Users/azat/Developer/eslint-plugin-perfectionist/node_modules/.pnpm/[email protected][email protected][email protected]_/node_modules/eslint-plugin-eslint-plugin/lib/rules/require-meta-schema-description.js:96:19)
    at Object.create (/Users/azat/Developer/eslint-plugin-perfectionist/node_modules/.pnpm/[email protected][email protected][email protected]_/node_modules/eslint-plugin-eslint-plugin/lib/rules/require-meta-schema-description.js:49:7)
    at createRuleListeners (/Users/azat/Developer/eslint-plugin-perfectionist/node_modules/.pnpm/[email protected][email protected]/node_modules/eslint/lib/linter/linter.js:944:21)
    at /Users/azat/Developer/eslint-plugin-perfectionist/node_modules/.pnpm/[email protected][email protected]/node_modules/eslint/lib/linter/linter.js:1082:84
    at Array.forEach (<anonymous>)
    at runRules (/Users/azat/Developer/eslint-plugin-perfectionist/node_modules/.pnpm/[email protected][email protected]/node_modules/eslint/lib/linter/linter.js:1013:34)
    at #flatVerifyWithoutProcessors (/Users/azat/Developer/eslint-plugin-perfectionist/node_modules/.pnpm/[email protected][email protected]/node_modules/eslint/lib/linter/linter.js:1911:31)
    at Linter._verifyWithFlatConfigArrayAndWithoutProcessors (/Users/azat/Developer/eslint-plugin-perfectionist/node_modules/.pnpm/[email protected][email protected]/node_modules/eslint/lib/linter/linter.js:1993:49)
    at Linter._verifyWithFlatConfigArray (/Users/azat/Developer/eslint-plugin-perfectionist/node_modules/.pnpm/[email protected][email protected]/node_modules/eslint/lib/linter/linter.js:2082:21)

Oops! Something went wrong! :(

ESLint: 9.15.0

aladdin-add
aladdin-add approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add force-pushed the fix/meta-schema-description-crash branch from 1c8b501 to e639835 Compare November 18, 2024 03:28
@aladdin-add
Copy link
Contributor

aladdin-add commented Nov 18, 2024 •
edited
Loading

can you please fix the linting errors?

no worries, I've amended the commit and cherry-picked to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aladdin-add aladdin-add aladdin-add approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azat-io @aladdin-add