Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Display and calculation of sponsors #656

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Oct 30, 2024

Prerequisites checklist

What is the purpose of this pull request?

Fix sponsors display

What changes did you make? (Give an overview)

  1. Ensure that sponsors with null names and images are still displayed on the sponsors page
  2. Ensure that sponsors who give enough money each month are properly credited in the correct tier (Cybozu was incorrectly not displayed as a bronze sponsor -- this was due to an error in fetch-sponsors)

The first issue was causing the website build to fail.

Related Issues

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Oct 30, 2024
Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for new-eslint ready!

Name Link
🔨 Latest commit d383762
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/672255fe6beb6d00087bb91e
😎 Deploy Preview https://deploy-preview-656--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit d383762
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/672255fee050d10008abe3c1
😎 Deploy Preview https://deploy-preview-656--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit d383762
🔍 Latest deploy log https://app.netlify.com/sites/es-eslint/deploys/672255feedd23d00082014a4
😎 Deploy Preview https://deploy-preview-656--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit d383762
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/672255fe68f2c000086a4c5f
😎 Deploy Preview https://deploy-preview-656--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit d383762
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/672255fe9a39c80008e2b32a
😎 Deploy Preview https://deploy-preview-656--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit d383762
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/672255fef0c9650008938a93
😎 Deploy Preview https://deploy-preview-656--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit d383762
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/672255fe16c94d000847a2e5
😎 Deploy Preview https://deploy-preview-656--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit d383762
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/672255fe6eaeb4000847707a
😎 Deploy Preview https://deploy-preview-656--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@amareshsm amareshsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for 2nd review.

Copy link
Member

@harish-sethuraman harish-sethuraman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harish-sethuraman harish-sethuraman merged commit 919428d into main Oct 31, 2024
37 checks passed
@harish-sethuraman harish-sethuraman deleted the null-sponsor-image branch October 31, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted bug Something isn't working
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

4 participants