ISSUE-63: Upgrade from RC3 to 1.0.0 doc needs edits #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiegoPino
requested changes
Sep 6, 2022
| ```shell | ||
| cp docker-compose-osx.yml docker-compose.yml | ||
| ``` | ||
| Then copy the appropriate `docker-compose` file for your architecture: |
There was a problem hiding this comment.
@aksm a step is missing here. The user should always backup the original docker-compose.yml. Most of our users end customizing/adding/removing configs and when doing the copy they overwrite all their particularities. Also a git diff example would be great
There was a problem hiding this comment.
Ok, does this look ok? 247c2be
docs/upgradeFromRC3.md
Outdated
| @@ -217,6 +210,7 @@ Important here is the `STATUS` column. It **needs** to be a number that goes up | |||
| ### Step 3: | |||
|
|
|||
| Instead of using the provided `composer.lock` out of the box we are going to loosen certain dependencies and bring manually Archipelago modules, all this to make update easier and future upgrades less of a pain. | |||
There was a problem hiding this comment.
We provide now a composer.lock.default. We also need to be sure that the user doing this runs all composer require against the original (their) composer.lock and not against the new default one
There was a problem hiding this comment.
And does this make sense? 8a7361c
added 5 commits
September 6, 2022 15:17
DiegoPino
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves part of #63