-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the OC pin usage of CH422G #7
Conversation
Hi @H-sw123, Thank you very much for your contribution. I reviewed the method you implemented, and it is quite good. However, I have the following two thoughts:
Also, quite coincidentally, I just implemented such a feature as well, and it’s in another PR #6 . If you're interested, could you please help me review and test it? Thank you very much. |
Hi @Lzw655 , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These modifications are very well-structured, thank you very much for your contribution!
I have one final suggestion: considering that TestCH422G.ino
is only used for CH422G, we can directly use ESP_IOExpander_CH422G
, which would eliminate the need for using static_cast<ESP_IOExpander_CH422G *>
for conversion.
b1a6a2a
to
5531264
Compare
Verified on waveshare ESP32 S3 Touch LCD 4.3B.
Arduino IDE Serial Monitor:
Hardware connection:
Added control interface for pins 8~11 of CH422G.