Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

box-emu: Update to explicitly define io address and improve loggingg #83

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

finger563
Copy link
Contributor

Description

  • Add io address for version 0 and version 1
  • Update logging when hardware cannot be found

Motivation and Context

Helps with debugging hardware and more useful in the future when more variants may exist.

How has this been tested?

Building and running on box and box-3.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 self-assigned this Jul 25, 2024
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit ebd8a98 into main Jul 25, 2024
3 checks passed
@finger563 finger563 deleted the chore/box-emu-logging branch July 25, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant