Make try_from() return the actual error with the partition table. #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The try_from() function used to just try both binary and csv partition tables, which resulted in a situation where it's unknown which of the two produced a sensible error.
By checking for the magic bytes 0xAA 0x50 at the start we can know which type of file we are dealing with and parse that type, and return errors accordingly. It also makes Error::InvalidPartitionTable obsolete as it was only used in this specific scenario.
Errors from espflash now look like this:
Should resolve #20