Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EspLogger::log without colors (CONFIG_LOG_COLORS=n) misses newline #520

Closed
FrigoEU opened this issue Nov 22, 2024 · 1 comment · Fixed by #521
Closed

EspLogger::log without colors (CONFIG_LOG_COLORS=n) misses newline #520

FrigoEU opened this issue Nov 22, 2024 · 1 comment · Fixed by #521

Comments

@FrigoEU
Copy link

FrigoEU commented Nov 22, 2024

Since this commit #494, when you write a log item without colors, a newline at the end is missing. Specifically because of this commit: 74c7a27

Now if the color variable is None, writeln! is never being called. Is it as simple as just else { writeln!("")}?

@FrigoEU
Copy link
Author

FrigoEU commented Nov 22, 2024

Thanks a lot for the swift action!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant