Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing newline if CONFIG_LOG_COLORS=n is set #521

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

mike1703
Copy link
Contributor

Fixes #520 where no newlines were printed if CONFIG_LOG_COLORS=n as the newline was only printed if color.is_some().
Now the writeln!() call is at the end and is always called.

@ivmarkov
Copy link
Collaborator

Thanks!

@ivmarkov ivmarkov merged commit 692e837 into esp-rs:master Nov 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EspLogger::log without colors (CONFIG_LOG_COLORS=n) misses newline
2 participants