Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESP32-S2 CopyDMA and CryptoDMA #302

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Add ESP32-S2 CopyDMA and CryptoDMA #302

wants to merge 7 commits into from

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Nov 20, 2024

Based on the ESP32-S2 TRM v1.1. PAC is not yet generated to make it somewhat reviewable.

Copy link
Contributor

@playfulFence playfulFence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I don't really want to add more files in that repo...

Even though the patch is really huge (thanks for taking care of this btw! ❤️ ), I'd like to see even such big changes in package/chip.yaml files.
They'll eventually get erased anyway, but at least we'll be somehow consistent in patching and not make an even bigger mess here.

@bugadani
Copy link
Contributor Author

I'm really not sure why you'd want to see a thousand lines of pure additive definitions be merged with 400 lines of random small changes, especially that the main patch file includes a bunch of other things anyway. This way the actual patches are separated from the new functionality instead of being mixed with them.

@burrbull
Copy link
Contributor

if those peripherals are mostly identical you could just "_copy" them from another SVD file by file_path:per_name

@bugadani
Copy link
Contributor Author

if those peripherals are mostly identical you could just "_copy" them from another SVD file by file_path:per_name

What are you suggesting, exactly? Copy from where, these peripherals don't exist in SVD files.

@burrbull
Copy link
Contributor

sorry. just saw "copy" word from phone and big add and decided this a copy from other file

@bugadani
Copy link
Contributor Author

Alas, no, the peripheral is called Copy DMA :(

@bugadani
Copy link
Contributor Author

My plan is to try and implement crypto dma in esp-hal, iterate on the PAC if I need to, then merge the new additions back to esp32s2.yaml after I'm confident I don't have to change them.

@playfulFence
Copy link
Contributor

@bugadani
I agree with you, having changes for each peripheral in a separate file is quite convenient, I, for example, sometimes get tired of searching through a huge .yaml patch for the section I'm interested in, but then we should take the time to do the same for all patches of all peripherals.
Now, to maintain consistency (and not to make an even bigger mess of this repo 😅 ), I would still insist that these changes should be made in that one huge chip-wide file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants