-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ESP32-S2 CopyDMA and CryptoDMA #302
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I don't really want to add more files in that repo...
Even though the patch is really huge (thanks for taking care of this btw! ❤️ ), I'd like to see even such big changes in package/chip.yaml files.
They'll eventually get erased anyway, but at least we'll be somehow consistent in patching and not make an even bigger mess here.
I'm really not sure why you'd want to see a thousand lines of pure additive definitions be merged with 400 lines of random small changes, especially that the main patch file includes a bunch of other things anyway. This way the actual patches are separated from the new functionality instead of being mixed with them. |
if those peripherals are mostly identical you could just "_copy" them from another SVD file by file_path:per_name |
What are you suggesting, exactly? Copy from where, these peripherals don't exist in SVD files. |
sorry. just saw "copy" word from phone and big add and decided this a copy from other file |
Alas, no, the peripheral is called Copy DMA :( |
My plan is to try and implement crypto dma in esp-hal, iterate on the PAC if I need to, then merge the new additions back to esp32s2.yaml after I'm confident I don't have to change them. |
@bugadani |
Based on the ESP32-S2 TRM v1.1. PAC is not yet generated to make it somewhat reviewable.