Refactor and simplify the `elf` module a bit #796

jessebraham · 2025-02-28T10:45:11Z

Eliminated the ElfFirmwareImage struct, as this was essentially just wrapping xmas_elf::ElfFile
Merged RomSegment and CodeSegment structs into a new Segment struct, as they were identical
Re-export a couple types from the elf module which are present in public APIs
Removed unused segments_with_load_addresses function from FirmwareImage trait

…ment`

SergioGasquez

LGTM! This is a nice step for #792, I also really like the renaming of some variables from image to elf, I had this pending.

jessebraham added 3 commits February 28, 2025 11:27

Eliminate the ElfFirmwareImage struct

f76c0d4

Eliminate redundant RomSegment struct, rename CodeSegment to `Seg…

cb1081f

…ment`

Re-export types which need to be public from elf module

e60669c

jessebraham requested a review from SergioGasquez February 28, 2025 10:45

jessebraham added 2 commits February 28, 2025 11:45

Update CHANGELOG.md

8172a19

Remove unused segments_with_load_addresses function

f59239b

SergioGasquez approved these changes Feb 28, 2025

View reviewed changes

jessebraham added this pull request to the merge queue Feb 28, 2025

Merged via the queue into esp-rs:main with commit f73fef4 Feb 28, 2025
24 checks passed

jessebraham deleted the refactor/elf branch February 28, 2025 11:15

Provide feedback