Skip to content

ci(pre-commit): Lock versions to SHA and apply fixes #11248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lucasssvaz
Copy link
Collaborator

@lucasssvaz lucasssvaz commented Apr 14, 2025

Description of Change

Lock the pre-commit versions to hashes to avoid security issues.
Execute codespell after formatting changes so the warnings will actually match the line numbers in the file.
Apply fixes by pre-commit.

Tests scenarios

CI and local

Copy link
Contributor

github-actions bot commented Apr 14, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello lucasssvaz, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 5981b0a

@lucasssvaz lucasssvaz changed the title ci(pre-commit): Execute codespell after formatting changes ci(pre-commit): Lock versions to SHA and apply fixes Apr 14, 2025
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32P4000.000.00000.000.00
ESP32S3000.000.00000.000.00
ESP32S2000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32P4ESP32S3ESP32S2
ExampleFLASHRAMFLASHRAMFLASHRAM
libraries/USB/examples/CompositeDevice000000
libraries/USB/examples/ConsumerControl000000
libraries/USB/examples/CustomHIDDevice000000
libraries/USB/examples/FirmwareMSC000000
libraries/USB/examples/Gamepad000000
libraries/USB/examples/HIDVendor000000
libraries/USB/examples/Keyboard/KeyboardLogout000000
libraries/USB/examples/Keyboard/KeyboardMessage000000
libraries/USB/examples/Keyboard/KeyboardReprogram000000
libraries/USB/examples/Keyboard/KeyboardSerial000000
libraries/USB/examples/KeyboardAndMouseControl000000
libraries/USB/examples/MIDI/MidiController000000
libraries/USB/examples/MIDI/MidiInterface000000
libraries/USB/examples/MIDI/MidiMusicBox000000
libraries/USB/examples/MIDI/ReceiveMidi000000
libraries/USB/examples/Mouse/ButtonMouseControl000000
libraries/USB/examples/SystemControl000000
libraries/USB/examples/USBMSC000000
libraries/USB/examples/USBSerial000000
libraries/USB/examples/USBVendor000000

Copy link
Contributor

github-actions bot commented Apr 14, 2025

Test Results

 76 files   76 suites   12m 45s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit 5981b0a.

♻️ This comment has been updated with latest results.

@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: CI & Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants