Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"#include "esp_idf_version.h" missing in lvgl9 version of file "esp_lvgl_port_disp.c" (BSP-486) #321

Closed
1 task done
MikeOchtman opened this issue Apr 23, 2024 · 1 comment · Fixed by #320
Closed
1 task done
Labels
Area: LVGL related to LVGL and LVGL port

Comments

@MikeOchtman
Copy link

Board

ESP32S3

Hardware Description

FREENOVE ESP32-S3 WROOM

IDE Name

VSCode

Operating System

Windows 10

Description

The macro ESP_IDF_VERSION_VAL is not defined in file "managed_components\espressif__esp_lvgl_port\src\lvgl9\esp_lvgl_port_disp.c" because "esp_idf_version.h" is not #included in any of the headers or source files in the compilation unit.

It also cannot be included by user without breaking the managed component relationship.

Sketch

/* the file includes the macro in the first and subsequent 'if' statements as below */
#include "esp_log.h"
#include "esp_err.h"
#include "esp_check.h"
#include "esp_heap_caps.h"
#include "esp_lcd_panel_io.h"
#include "esp_lcd_panel_ops.h"
#include "esp_lvgl_port.h"

#if (CONFIG_IDF_TARGET_ESP32P4 && ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(5, 3, 0))
{
}

Other Steps to Reproduce

No response

I have checked existing issues, README.md and ESP32 Forum

  • I confirm I have checked existing issues, online documentation and Troubleshooting guide.
@github-actions github-actions bot changed the title "#include "esp_idf_version.h" missing in lvgl9 version of file "esp_lvgl_port_disp.c" "#include "esp_idf_version.h" missing in lvgl9 version of file "esp_lvgl_port_disp.c" (BSP-486) Apr 23, 2024
@espzav
Copy link
Collaborator

espzav commented Apr 24, 2024

Hi @MikeOchtman,
This PR is solving this issue: #320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: LVGL related to LVGL and LVGL port
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants