Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lvgl port updates #320

Merged
merged 8 commits into from
May 14, 2024
Merged

Lvgl port updates #320

merged 8 commits into from
May 14, 2024

Conversation

espzav
Copy link
Collaborator

@espzav espzav commented Apr 11, 2024

ESP-BSP Pull Request checklist

  • Version of modified component bumped
  • CI passing

Change description

I made lot of small changes in one PR. Some are from custommers, some are improvements.

@espzav
Copy link
Collaborator Author

espzav commented Apr 11, 2024

@tore-espressif PTAL

Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@espzav Thank you very much for the changes! I'm OK with doing it all in one PR, but I will need more review rounds :(

components/esp_lvgl_port/CHANGELOG.md Outdated Show resolved Hide resolved
examples/display/main/images/esp_logo.c Show resolved Hide resolved
components/esp_lvgl_port/README.md Outdated Show resolved Hide resolved
components/esp_lvgl_port/src/lvgl8/esp_lvgl_port.c Outdated Show resolved Hide resolved
components/esp_lvgl_port/project_include.cmake Outdated Show resolved Hide resolved
@espzav espzav force-pushed the lvgl_port_updates branch 2 times, most recently from b496c2a to 8139d6f Compare April 16, 2024 10:08
@espzav espzav requested a review from igrr April 16, 2024 12:00
@espzav espzav force-pushed the lvgl_port_updates branch 3 times, most recently from b49e39d to 5f34511 Compare April 19, 2024 07:39
@espzav
Copy link
Collaborator Author

espzav commented Apr 19, 2024

@tore-espressif Thank you for review! I fixed everything - except new component for C array script for LVGL8. I am not sure, that it is good idea.

@espzav espzav added the Area: LVGL related to LVGL and LVGL port label Apr 19, 2024
Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@espzav Thank you for the update!

My only remaining concern is about C image generation on LVGL8. The script only generates configuration for LV_COLOR_DEPTH == 16 && LV_COLOR_16_SWAP == 0 which is not suitable for the most of our BSPs as they use LV_COLOR_16_SWAP

components/esp_lvgl_port/CHANGELOG.md Outdated Show resolved Hide resolved
components/esp_lvgl_port/src/lvgl9/esp_lvgl_port.c Outdated Show resolved Hide resolved
components/esp_lvgl_port/CHANGELOG.md Outdated Show resolved Hide resolved
components/esp_lvgl_port/README.md Outdated Show resolved Hide resolved
components/esp_lvgl_port/include/esp_lvgl_port.h Outdated Show resolved Hide resolved
components/esp_lvgl_port/project_include.cmake Outdated Show resolved Hide resolved
examples/display/main/esp_logo.c Show resolved Hide resolved
@espzav
Copy link
Collaborator Author

espzav commented Apr 30, 2024

Hi, I found one issue. When I am using display (https://github.com/espressif/esp-bsp/tree/master/examples/display) example with SPI/DSI display, it is not working properly with this line:

task_delay_ms = lvgl_port_ctx.task_max_sleep_ms;
and this line
xQueueReceive(lvgl_port_ctx.lvgl_queue, &event, pdMS_TO_TICKS(task_delay_ms));

I fixed it - reworked task sleeping with LVGL help.

@espzav espzav force-pushed the lvgl_port_updates branch 2 times, most recently from c712f05 to 3cdb55f Compare May 9, 2024 06:58
@espzav
Copy link
Collaborator Author

espzav commented May 9, 2024

@tore-espressif Please, could you continue here? The next PR #322 depends on this. Thannk you

@tore-espressif tore-espressif self-requested a review May 9, 2024 08:29
Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great amount of work @espzav !
LGTM, only nitpicks about CMake :)

@espzav
Copy link
Collaborator Author

espzav commented May 14, 2024

@tore-espressif Thank you for the review!

@espzav espzav merged commit 0f4476a into master May 14, 2024
23 checks passed
@espzav espzav deleted the lvgl_port_updates branch May 14, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: LVGL related to LVGL and LVGL port
Projects
None yet
3 participants