-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lvgl port updates #320
Lvgl port updates #320
Conversation
5e0942a
to
942baca
Compare
893bd78
to
68156b7
Compare
@tore-espressif PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@espzav Thank you very much for the changes! I'm OK with doing it all in one PR, but I will need more review rounds :(
b496c2a
to
8139d6f
Compare
b49e39d
to
5f34511
Compare
@tore-espressif Thank you for review! I fixed everything - except new component for C array script for LVGL8. I am not sure, that it is good idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@espzav Thank you for the update!
My only remaining concern is about C image generation on LVGL8. The script only generates configuration for LV_COLOR_DEPTH == 16 && LV_COLOR_16_SWAP == 0
which is not suitable for the most of our BSPs as they use LV_COLOR_16_SWAP
5f34511
to
d1ea532
Compare
ae5ccb9
to
0350c47
Compare
6a43918
to
487e55b
Compare
6899514
to
8ef4943
Compare
Hi, I found one issue. When I am using display (https://github.com/espressif/esp-bsp/tree/master/examples/display) example with SPI/DSI display, it is not working properly with this line:
I fixed it - reworked task sleeping with LVGL help. |
c712f05
to
3cdb55f
Compare
@tore-espressif Please, could you continue here? The next PR #322 depends on this. Thannk you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the great amount of work @espzav !
LGTM, only nitpicks about CMake :)
@tore-espressif Thank you for the review! |
ESP-BSP Pull Request checklist
Change description
I made lot of small changes in one PR. Some are from custommers, some are improvements.
Apply display rotation from configuration (Closes esp_lvgl_port: apply rotation from display configuration (BSP-443) #278)
Added unit test
Wait for stop task when deinit (Closes lvgl_port_deinit() returns ESP_OK before the LVGL task has actually stopped (BSP-442) #277)
Wake LVGL task from touch and display when set big maximum sleep
Allow to select color format with LVGL9
Generate C arrays for images during build process
Added missing esp_idf_version.h include (Closes "#include "esp_idf_version.h" missing in lvgl9 version of file "esp_lvgl_port_disp.c" (BSP-486) #321)
Updated LVGL demos example for ESP-P4
Fixed M5Stack Core S3 rotation (Closes M5Stack Core S3 Display up side down (BSP-494) #328)