s3-lcd-ev-board: add display & touch, update docs

[Lzw655]

ESP-BSP Pull Request checklist

Note: For new BSPs create a PR with this link.

• Version of modified component bumped
• CI passing

Change description

• Configurations:
  • Add support for screen rotation using triple buffers when enabling RGB anti-tearing.
  • Add support for configuring SPIFFS.
• Implementations:
  • Use esp_lcd_panel_io_additions and esp_lcd_gc9503 components to drive the LCD of sub_board2.
  • Use esp_codec_dev component to handle audio chips.
  • Implement automatic detection of the LCD sub-board type
• APIs:
  • Add new APIs for display in bsp/display.h
  • Add new APIs for touch in bsp/touch.h
  • Add new APIs for spiffs, audio in bsp/esp32_s3_lcd_ev_board.h

[Lzw655]

@tore-espressif @espzav @espressif2022 PTAL, thank you!

[espzav]

Hi @Lzw655, thank you for changes in s3-lcd-ev-board, I will make review soon. But please, do not make changes in other BSPs in the same PR, which are not relevant for this PR. I am making lot of changes in BSPs now, I can add these fixes, but I will make it board per board, for better clarity.

Please split it into two PRs or add comment into my PR (e.g. https://github.com/espressif/esp-bsp/pull/201/files).

The next thing, we are supporting IDF4.4 now. Please, is it possible support IDF4.4 in s3-lcd-ev-board too (BSP-344)?

Thank you for your work!

[Lzw655]

Hi @Lzw655, thank you for changes in s3-lcd-ev-board, I will make review soon. But please, do not make changes in other BSPs in the same PR, which are not relevant for this PR. I am making lot of changes in BSPs now, I can add these fixes, but I will make it board per board, for better clarity.

Please split it into two PRs or add comment into my PR (e.g. https://github.com/espressif/esp-bsp/pull/201/files).

The next thing, we are supporting IDF4.4 now. Please, is it possible support IDF4.4 in s3-lcd-ev-board too (BSP-344)?

Thank you for your work!

Sure, I will remove the modifications from other BSPs.

However, because the drivers in release/v4.4 lack some critical features such as "RGB bounce buffer," "XIP on PSRAM," and "PSRAM Octal 120M," we do not encourage customers to use release/v4.4 for RGB LCD development.

[espzav]

Hi @Lzw655 I am making review for your PR and testing on HW. I have 800x480 screen.

1. I see, that you add support for EV board into display_audio_photo example. That's great, thank you. I have one suggestion. We can change the size of the file list like this: line 721: lv_obj_set_size(fs_list, BSP_LCD_H_RES, BSP_LCD_V_RES-40);
2. The screen is little blinking - the refresh frequency is visible - mainly on TABs and JPEG image.

I am continuing now with a review.

[Lzw655]

Hi @espzav , thank you for reviewing.

1. Yeah, It's a good suggestion. I'll modify it after you finish the review.
2. Are you using an early development board? Some of those boards have a known issue where if they work for a period of time, such as after flashing the firmware for an extended period, the screen might start flickering. Powering off the board and leaving it for a while can restore normal operation. Newer development boards don't experience this issue.

[espzav]

2. Are you using an early development board? Some of those boards have a known issue where if they work for a period of time, such as after flashing the firmware for an extended period, the screen might start flickering. Powering off the board and leaving it for a while can restore normal operation. Newer development boards don't experience this issue.

Thank you for info. I have MB v1.1 (from 2022.10.10) and SUB3 v1.0 (from 2022.06.17).

[Lzw655]

2. Are you using an early development board? Some of those boards have a known issue where if they work for a period of time, such as after flashing the firmware for an extended period, the screen might start flickering. Powering off the board and leaving it for a while can restore normal operation. Newer development boards don't experience this issue.

Thank you for info. I have MB v1.1 (from 2022.10.10) and SUB3 v1.0 (from 2022.06.17).

Well, the SUB3 v1.0 is an older version. I'm using v1.3 now. 😂

[espzav]

FYI: We have plan for add RGB display support into esp_lvgl_port (BSP-300). I see, that it is now closer to achieve it. Is it possible to update and use esp_lvgl_port instead of bsp_lvgl_port.c file? If yes, and if you want to help with this, could you make it as a new PR? I can help with this, if you want :-)
I see only one thing, which is not right for using in esp_lvgl_port: bsp_display_register_trans_done_callback - no BSP inside LVGL port. And we should avoid some ifdefs and make it runtime ;-)

[Lzw655]

FYI: We have plan for add RGB display support into esp_lvgl_port (BSP-300). I see, that it is now closer to achieve it. Is it possible to update and use esp_lvgl_port instead of bsp_lvgl_port.c file? If yes, and if you want to help with this, could you make it as a new PR? I can help with this, if you want :-) I see only one thing, which is not right for using in esp_lvgl_port: bsp_display_register_trans_done_callback - no BSP inside LVGL port. And we should avoid some ifdefs and make it runtime ;-)

Yes, I strongly agree with this comprehensive approach. It should be achievable in the esp_lvgl_port, but adapting these anti-tearing solutions there comes with a certain level of complexity and will require some time. I'll only have availability for this in two weeks.

[espzav]

Yes, I strongly agree with this comprehensive approach. It should be achievable in the esp_lvgl_port, but adapting these anti-tearing solutions there comes with a certain level of complexity and will require some time. I'll only have availability for this in two weeks.

Ok, I understand. We will do it later.

[espzav]

@Lzw655 Thank you very much for these changes. It was complicated for review, there are lot of changes. I hope, that I understand everything right. It looks good, but there should be make some changes before merge.

[espzav]

@Lzw655 Thank you for changes! LGTM

[Lzw655]

@espzav Can we merge it?