Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsp: Add support for LVGL and new API into esp32_azure_iot_kit #207

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

espzav
Copy link
Collaborator

@espzav espzav commented Aug 15, 2023

ESP-BSP Pull Request checklist

  • Version of modified component bumped
  • CI passing

Change description

  • Updated ESP32-AZURE-IoT Kit with new BSP API
    • Added some missing APIs (e.g. SPIFFS)
    • Updated some old APIs (e.g. buttons)
    • Added LCD API
    • Added LVGL API
    • Updated both examples with new API

@espzav espzav force-pushed the bsp/new_api_esp32_azure_iot_kit branch 2 times, most recently from 6c7f84e to acef64f Compare August 18, 2023 05:46
@espzav
Copy link
Collaborator Author

espzav commented Aug 18, 2023

Hello, @leeebo, @Lzw655, @espressif2022, could you please help with review? Thanks

@espzav espzav requested review from tore-espressif and igrr August 18, 2023 07:58
Copy link
Collaborator

@Lzw655 Lzw655 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @espzav, LGTM! But I don't have a board to test. And only two comments left.

@espzav espzav force-pushed the bsp/new_api_esp32_azure_iot_kit branch from acef64f to 51e996d Compare August 18, 2023 10:01
@espzav
Copy link
Collaborator Author

espzav commented Aug 18, 2023

@Lzw655 Thank you for review! Everything fixed.

Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@espzav I left few nitpicks.

Again, I'd like to try on HW too (next week)

@espzav espzav force-pushed the bsp/new_api_esp32_azure_iot_kit branch from 51e996d to 2e0c802 Compare September 8, 2023 07:29
Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rotation of dispaly works good, LGTM!

@espzav espzav force-pushed the bsp/new_api_esp32_azure_iot_kit branch from 2e0c802 to 2f02562 Compare September 13, 2023 08:05
@espzav espzav merged commit 191e7fd into master Sep 13, 2023
@espzav espzav deleted the bsp/new_api_esp32_azure_iot_kit branch September 13, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants