lcd_touch_ft5x06: Fixed missing reset.

[espzav]

ESP-BSP Pull Request checklist

• Version of modified component bumped
• CI passing

Change description

Fixed missing reset call in esp_lcd_touch_ft5x06.
Fixed interrupt level in all touch drivers.
Closes #211

[Lzw655]

@espzav Oh, there is one more thing. We should remove the ISR handler in del() like below:

    if (tp->config.rst_gpio_num != GPIO_NUM_NC) {
        gpio_reset_pin(tp->config.rst_gpio_num);
        if (tp->config.interrupt_callback) {
            gpio_isr_handler_remove(tp->config.int_gpio_num);
        }
    }

[tore-espressif]

Overall LGTM.

But I agree with @Lzw655 that we could use this PR for fixing the 'delete' behavior.

Moreover, I'd suggest moving the 'delete' function to the base component esp_lcd_touch.
So the esp_lcd_touch would deregister the ISR and reset all pins to default. What do you think @espzav ?

Becasue this section of code

/* Reset GPIO pin settings */
    if (tp->config.int_gpio_num != GPIO_NUM_NC) {
        gpio_reset_pin(tp->config.int_gpio_num);
    }

    /* Reset GPIO pin settings */
    if (tp->config.rst_gpio_num != GPIO_NUM_NC) {
        gpio_reset_pin(tp->config.rst_gpio_num);
    }

is called from every touch driver, but the base esp_lcd_touch can do it, too

[espzav]

Moreover, I'd suggest moving the 'delete' function to the base component esp_lcd_touch.
So the esp_lcd_touch would deregister the ISR and reset all pins to default. What do you think @espzav ?

I partially agree, but it wouldn't be consistent, because initialization will be in end driver ( esp_lcd_touch_xxx), but removing in esp_lcd_touch. Are you sure, that it is good solution?

[tore-espressif]

I partially agree, but it wouldn't be consistent, because initialization will be in end driver ( esp_lcd_touch_xxx), but removing in esp_lcd_touch. Are you sure, that it is good solution?

True, unless we can move the initialization to the base esp_lcd_touch too, we can leave it as it is

[espzav]

@tore-espressif and @Lzw655 Thank you for review. All changes done.

@tore-espressif Could we merge it?

[tore-espressif]

LGTM!