-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LVGL: Add support of LVGL9 into LVGL port #268
Conversation
e8165d6
to
3867e25
Compare
6e7b10e
to
d57eaa9
Compare
e1a25c4
to
6657c49
Compare
95a4816
to
3068390
Compare
@tore-espressif PTAL
|
9fe9e50
to
3ae4699
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@espzav great job! I left few comments that might be worth considering
@tore-espressif Thank you for review. Fixed all except mail
|
8f308cf
to
9ad2b6b
Compare
My last commit fixing usage of FPS monitor. I don't know, if it is right solution or workaround - I am discussing with Gabor: lvgl/lvgl#4926 (comment) |
Hi @espzav, I also tried to port LVGL v9, and I've encountered some issues when using multiple CPU cores to render in parallel, and I'd like to share them with you:
BTW, it indeed improves the performance by using multiple CPU cores. By running the v8 benchmark demo, the use of 2-unit increased the weighted FPS from 51 to 73 compared to a 1-unit. |
Here is the fix in LVGL: lvgl/lvgl#5518 |
@Lzw655 Thank you for info, I will try it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@espzav few more details :)
@tore-espressif Thank you for your review! All fixed. Is it ok, can we merge it now? |
I can see that the CI is still using LVGL 8 https://github.com/espressif/esp-bsp/actions/runs/7707868489/job/21005817735?pr=268#step:4:186 Could you please add This way, the CI and local builds will automatically pick After the CI passes with LVGL9 build, we should be good to merge :) |
ESP-BSP Pull Request checklist
Change description
Support of LVGL9 in ESP LVGL port (including support LVGL8 too).
LVGL9 supported parts:
Other things not supported with LVGL9:
- [ ] lv_obj_set_style_image_opaTODO (Create Jira tickets)