Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ds18b20): fix the wrong value of a sub-zero temperature (BSP-444) #279

Conversation

suda-morris
Copy link
Collaborator

@suda-morris suda-morris commented Jan 16, 2024

because of the drop in the sign when doing the temperature conversion

Closes #258

ESP-BSP Pull Request checklist

Note: For new BSPs create a PR with this link.

  • Version of modified component bumped
  • CI passing

Change description

Please describe your change here

because of the drop of the sign when doing the temperature conversion

Closes espressif#258
@suda-morris
Copy link
Collaborator Author

@tore-espressif @morgana2313 PTAL

@github-actions github-actions bot changed the title fix(ds18b20): fix the wrong value of a sub-zero temperature fix(ds18b20): fix the wrong value of a sub-zero temperature (BSP-444) Jan 16, 2024
@tore-espressif tore-espressif merged commit 539f656 into espressif:master Jan 22, 2024
21 checks passed
@suda-morris suda-morris deleted the bugfix/ds18b20_temperature_conversion branch January 22, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ds18b20 temperature freezing wrong (BSP-419)
3 participants