-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bsp: Add M5Stack CoreS3 #301
Conversation
6991d43
to
9e86fe3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@espzav I left few house-keeping notes. Will continue later
94e09da
to
8f2dba3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
117229a
to
3512bf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left just a few nitpicks. LGTM.
Thank you @espzav!
@pborcin Thank you for review. Everything fixed. |
Checklist for new Board Support package or Component
url
field defined- [ ] New BSP supports IDF v4.4.x and later releases- [ ] Optional: Component contains unit testsChange description
❗ Audion still not working with IDF4.4 (working on it)