Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsp: Add M5Stack CoreS3 #301

Merged
merged 1 commit into from
Mar 12, 2024
Merged

bsp: Add M5Stack CoreS3 #301

merged 1 commit into from
Mar 12, 2024

Conversation

espzav
Copy link
Collaborator

@espzav espzav commented Feb 27, 2024

Checklist for new Board Support package or Component

  • Component contains License
  • Component contains README.md
  • Project README.md updated
  • Component contains idf_component.yml file with url field defined
  • Component was added to CI upload job
  • New files were added to CI build job
  • New BSP definitions added to bsp_ext.py
  • BSP was added to SquareLine
    - [ ] New BSP supports IDF v4.4.x and later releases
    - [ ] Optional: Component contains unit tests
  • CI passing

Change description

  • Added audio support (Speaker + Mic).
  • Not working sharing SD card and LCD
  • IMU not supported
  • Proximity sensor not supported

❗ Audion still not working with IDF4.4 (working on it)

@espzav espzav force-pushed the bsp/m5stack_s3 branch 6 times, most recently from 6991d43 to 9e86fe3 Compare February 28, 2024 08:13
Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@espzav I left few house-keeping notes. Will continue later

bsp/m5stack_core_s3/.component_hash Outdated Show resolved Hide resolved
bsp/m5stack_core_s3/m5stack_core_s3_idf4.c Outdated Show resolved Hide resolved
bsp/m5stack_core_s3/README.md Outdated Show resolved Hide resolved
@espzav espzav force-pushed the bsp/m5stack_s3 branch 7 times, most recently from 94e09da to 8f2dba3 Compare March 5, 2024 13:09
Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@espzav One more comment about IDF compatibility :)

Let's wait for @pborcin HW test before merging

.build-test-rules.yml Show resolved Hide resolved
@espzav espzav force-pushed the bsp/m5stack_s3 branch 3 times, most recently from 117229a to 3512bf2 Compare March 8, 2024 07:20
Copy link
Collaborator

@pborcin pborcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left just a few nitpicks. LGTM.
Thank you @espzav!

bsp/m5stack_core_s3/include/bsp/m5stack_core_s3.h Outdated Show resolved Hide resolved
bsp/m5stack_core_s3/include/bsp/m5stack_core_s3.h Outdated Show resolved Hide resolved
bsp/m5stack_core_s3/include/bsp/m5stack_core_s3.h Outdated Show resolved Hide resolved
@espzav
Copy link
Collaborator Author

espzav commented Mar 8, 2024

@pborcin Thank you for review. Everything fixed.

@espzav espzav merged commit fcdc258 into master Mar 12, 2024
11 checks passed
@espzav espzav deleted the bsp/m5stack_s3 branch March 12, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants