Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating Issue templates (BSP-477) #311

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Creating Issue templates (BSP-477) #311

merged 1 commit into from
Apr 22, 2024

Conversation

Indastri
Copy link
Contributor

Issue templates for esp-bsp repository

@CLAassistant
Copy link

CLAassistant commented Mar 19, 2024

CLA assistant check
All committers have signed the CLA.

@VojtechBartoska VojtechBartoska added the Type: Documentation Improvements or additions to documentation label Mar 19, 2024
@VojtechBartoska VojtechBartoska self-requested a review March 19, 2024 15:56
@VojtechBartoska VojtechBartoska added the Status: Review needed PR is awaiting review. label Mar 19, 2024
@github-actions github-actions bot changed the title Creating Issue templates Creating Issue templates (BSP-477) Mar 19, 2024
@espzav
Copy link
Collaborator

espzav commented Mar 21, 2024

@Indastri Thank you for this PR. Please, how can I test it before merging?

Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Indastri Good work! It looks good.

Copy link
Contributor

@VojtechBartoska VojtechBartoska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR, added few comments.

.github/ISSUE_TEMPLATE/01_Feature-Request.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/02_Issue-Report.yml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/02_Issue-Report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/02_Issue-Report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/02_Issue-Report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved
@VojtechBartoska
Copy link
Contributor

@Indastri Thank you for this PR. Please, how can I test it before merging?

you can check it here: https://github.com/Indastri/esp-bsp/issues/new/choose

Copy link
Contributor

@VojtechBartoska VojtechBartoska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just 2 minor comments added.

.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved
@VojtechBartoska
Copy link
Contributor

@Indastri one more thing, in the repo are 2 Pull Requests templates, we can delete one of them and it should be done in this PR as it is related.

@VojtechBartoska
Copy link
Contributor

LGTM @Indastri, CI is not happy

@espzav
Copy link
Collaborator

espzav commented Apr 18, 2024

@Indastri LGTM. Have you got access rights for merge or should I merge it?

@Indastri
Copy link
Contributor Author

@espzav if you can please merge it. Thanks!

Created issue templates, removed extra PR template
@espzav espzav merged commit fa98394 into espressif:master Apr 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Review needed PR is awaiting review. Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants