bsp: New BSP for M5Dial (BSP-488) #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espzav
force-pushed
the
bsp/m5dial
branch
4 times, most recently
from
0573569 to
aec6d96
Compare
espzav
force-pushed
the
bsp/m5dial
branch
3 times, most recently
from
c1ece2b to
805a75b
Compare
|
@tore-espressif and @pborcin PTAL |
espzav
force-pushed
the
bsp/m5dial
branch
5 times, most recently
from
33f09a5 to
34d884a
Compare
tore-espressif
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
@espzav Thanks for the PR!
I tested the examples - all OK, and add few nitpick comments.
Next we can discuss support for the other board features, such as the RTC timer or RFID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for new Board Support package or Component
urlfield definedChange description