Feature/support i2c ng esp box #354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espzav
force-pushed
the
feature/support_i2c_ng_esp_box
branch
from
aa94350
to
3284337
Compare
| @@ -7,6 +7,7 @@ | |||
| #include "driver/gpio.h" | |||
| #include "driver/ledc.h" | |||
| #include "driver/spi_master.h" | |||
| #include "driver/i2c_master.h" | |||
There was a problem hiding this comment.
Should we remove #include "driver/i2c.h" from esp-box.h?
| @@ -1,5 +1,5 @@ | |||
|
|
|||
| version: "3.1.0" | |||
| version: "3.2.0" | |||
There was a problem hiding this comment.
This is actually a breaking change, because from now on, the users cannot use I2C legacy driver with this BSP.
The whole topic is probably more complicated than we anticipated, we can discuss offline
| public: true | ||
|
|
||
| button: | ||
| version: ">=2.5" | ||
| public: true | ||
|
|
||
| icm42670: | ||
| version: "^1" | ||
| version: "^2" |
There was a problem hiding this comment.
FYI: bumping major version of a public dependency is considered a breaking change :(
|
@espzav This board is obsolete now. Do you want to finish the PR or can we close? |
|
The board is obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP-BSP Pull Request checklist
Change description
The first PR, how to support I2C NG driver in BSP (esp-box).